Fix hovermode 'closest' + hoverinfo 'none' with superimposed data bug #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that superimposed trace hover data can skip over 'hoverinfo' traces upon hover label creation.
| @@ -618,7 +618,7 @@ fx.getClosest = function(cd, distfn, pointData) { | |||
| // do this for 'closest' | |||
| for(var i=0; i<cd.length; i++) { | |||
| var newDistance = distfn(cd[i]); | |||
| if(newDistance < pointData.distance) { | |||
| if(newDistance <= pointData.distance) { | |||
There was a problem hiding this comment.
yeah, it's a little hacky. Ideally hoverinfo: 'none' traces wouldn't be passed to the hover label routine, but that caused a plotly_hover test to fail, so I decided to go with ⏫ .
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #493
@mdtusz this commit c8b05ed in PR #438 introduced the bug in
v1.10.0.In brief
hoverinfo: 'none'traces used to be skipped over in the search-closest-data routine beforev1.10.0which fixed issue #313 . But, as a side-effect, that patch allowedFx.getClosestto pickhoverinfo: 'none'data points which were then passed to the hover label routine resulting in non apparent hover labels.More info on
Fx.getClosestNote that
hovermode: 'closest'only shows the hover label for the closest point. Previously, if two points were superimposed, only the data point of the first trace (as ordered indata) was passed to the hover label routine. Now, all superimposed points (i.e with the same distance to cursor) are passed to the hover label routine.