Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concentration and small fixes #4425

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ggbaro
Copy link
Contributor

@ggbaro ggbaro commented Dec 16, 2019

Thanks for your interest in plotly.js!

Translations:

  • Make a PR directly to the main repository
  • Please @ mention a few other speakers of this language who can help review your translations.
    @Domino987
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master,
  • make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
  • make sure to commit changes to the package-lock.json file (if any),
  • write an overview of what the PR attempts to do,
  • select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

@etpinard
Copy link
Contributor

Hi @ggbaro - thanks very much for the PR!

We'll need the approval from another native speaker before merging.

@gvwilson gvwilson self-assigned this Jun 10, 2024
@gvwilson
Copy link
Contributor

This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson

@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added feature something new community community contribution P2 considered for next cycle and removed type: translation labels Aug 8, 2024
@@ -14,15 +14,15 @@ module.exports = {
dictionary: {
'Autoscale': 'Scala automaticamente', // components/modebar/buttons.js:139
'Box Select': 'Selezione box', // components/modebar/buttons.js:103
'Click to enter Colorscale title': 'Clicca per inserire un titolo alla scala di colori', // plots/plots.js:437
'Click to enter Colorscale title': 'Clicca per inserire un titolo alla scala colori', // plots/plots.js:437
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a member of our community said that "scala di colori" would be more correct - can you please let us know?

Copy link
Contributor Author

@ggbaro ggbaro Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Scala colori" should be preferrable because it is common language. Scala di colori is formally correct but a bit byzantine

'Click to enter Component A title': 'Clicca per inserire un titolo al componente A', // plots/ternary/ternary.js:386
'Click to enter Component B title': 'Clicca per inserire un titolo al componente B', // plots/ternary/ternary.js:400
'Click to enter Component C title': 'Clicca per inserire un titolo al componente C', // plots/ternary/ternary.js:411
'Click to enter Plot title': 'Clicca per inserire un titolo al grafico', // plot_api/plot_api.js:579
'Click to enter X axis title': 'Clicca per inserire un titolo all\'asse X', // plots/plots.js:435
'Click to enter Y axis title': 'Clicca per inserire un titolo all\'asse Y', // plots/plots.js:436
'Click to enter radial axis title': 'Clicca per inserire un titolo per l\' asse radiale', // plots/plots.js:436
'Compare data on hover': 'Paragona i dati al passaggio del mouse', // components/modebar/buttons.js:167
'Compare data on hover': 'Compara i dati al passaggio del mouse', // components/modebar/buttons.js:167
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a member of our community has suggested that "Confronta" would be better that either "Paragona" or "Compara" - can you please let us know?

'Click to enter Component A title': 'Clicca per inserire un titolo al componente A', // plots/ternary/ternary.js:386
'Click to enter Component B title': 'Clicca per inserire un titolo al componente B', // plots/ternary/ternary.js:400
'Click to enter Component C title': 'Clicca per inserire un titolo al componente C', // plots/ternary/ternary.js:411
'Click to enter Plot title': 'Clicca per inserire un titolo al grafico', // plot_api/plot_api.js:579
'Click to enter X axis title': 'Clicca per inserire un titolo all\'asse X', // plots/plots.js:435
'Click to enter Y axis title': 'Clicca per inserire un titolo all\'asse Y', // plots/plots.js:436
'Click to enter radial axis title': 'Clicca per inserire un titolo per l\' asse radiale', // plots/plots.js:436
'Compare data on hover': 'Paragona i dati al passaggio del mouse', // components/modebar/buttons.js:167
'Compare data on hover': 'Compara i dati al passaggio del mouse', // components/modebar/buttons.js:167
'Double-click on legend to isolate one trace': 'Doppio click per isolare i dati di una traccia', // components/legend/handle_click.js:90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our community member says: I think it should be "Doppio click per isolare una traccia" or "Doppio click sulla legenda per isolare una traccia" - do you think either would be better here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Doppio click sulla legenda per isolare una traccia" is more correct.

'Click to enter Component A title': 'Clicca per inserire un titolo al componente A', // plots/ternary/ternary.js:386
'Click to enter Component B title': 'Clicca per inserire un titolo al componente B', // plots/ternary/ternary.js:400
'Click to enter Component C title': 'Clicca per inserire un titolo al componente C', // plots/ternary/ternary.js:411
'Click to enter Plot title': 'Clicca per inserire un titolo al grafico', // plot_api/plot_api.js:579
'Click to enter X axis title': 'Clicca per inserire un titolo all\'asse X', // plots/plots.js:435
'Click to enter Y axis title': 'Clicca per inserire un titolo all\'asse Y', // plots/plots.js:436
'Click to enter radial axis title': 'Clicca per inserire un titolo per l\' asse radiale', // plots/plots.js:436
'Compare data on hover': 'Paragona i dati al passaggio del mouse', // components/modebar/buttons.js:167
'Compare data on hover': 'Compara i dati al passaggio del mouse', // components/modebar/buttons.js:167
'Double-click on legend to isolate one trace': 'Doppio click per isolare i dati di una traccia', // components/legend/handle_click.js:90
'Double-click to zoom back out': 'Doppio click per tornare allo zoom iniziale', // plots/cartesian/dragbox.js:299
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community member suggests "Doppio click per ridurre" - please let us know what you think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Doppio click per ridurre" is ok. I'd say "Doppio click per ridurre lo zoom" as less ambiguous

@@ -45,20 +45,20 @@ module.exports = {
'Taking snapshot - this may take a few seconds': 'Creazione screenshot - potrebbe richiedere qualche secondo', // components/modebar/buttons.js:57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community member suggests "Facendo screenshot - ...." instead of "Creazione screenshot" - what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While "Facendo screenshot - ..." is the exact translation, in practice it would be far from common ui feedback messages, something like "While doing screenshot - ..." in english.

It could be a third way, like "Snapshot in corso - ..." (which translates to Snapshot in progress literally). This could work better in my opinion

@gvwilson gvwilson self-assigned this Nov 21, 2024
@gvwilson gvwilson merged commit eaf5725 into plotly:master Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants