Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt default axis ranges to rangemode #4171

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Sep 6, 2019

so that even if no _extremes stashes get filled in, ax.rangemode still as an effect.

fixes #4137 - cc @plotly/plotly_js

before: https://codepen.io/DaanyWaay/pen/eYOdNVV
after: https://codepen.io/etpinard/pen/dybJBzo

... so that even if no `_extremes` stash get filled in,
    ax.rangemode still as an effect.
@etpinard etpinard added bug something broken status: reviewable labels Sep 6, 2019
@archmoj
Copy link
Contributor

archmoj commented Sep 11, 2019

Nicely done.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rangemode is ignored if there is no data
2 participants