texttemplate with date formatting #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `textemplate` support to the following traces: - [x] pie - [x] sunburst - [x] funnelarea - [x] bar - [x] waterfall - [x] funnel - [x] scatter
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
etpinard
reviewed
Jul 23, 2019
| @@ -534,6 +537,64 @@ function getTextPosition(trace, index) { | |||
| return helpers.coerceEnumerated(attributeTextPosition, value); | |||
| } | |||
|
|
|||
| function calcTexttemplate(fullLayout, calcTrace, index, xa, ya) { | |||
There was a problem hiding this comment.
It would be nice to merge this routine with calcTextinfo where we could first set the obj.??Label values and then use those to translate the textinfo flags.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 26, 2019
etpinard
reviewed
Aug 28, 2019
| @@ -29,7 +29,7 @@ module.exports = { | |||
| moduleType: 'trace', | |||
| name: 'scatter3d', | |||
| basePlotModule: require('../../plots/gl3d'), | |||
| categories: ['gl3d', 'symbols', 'showLegend'], | |||
| categories: ['gl3d', 'symbols', 'showLegend', 'scatter-like'], | |||
There was a problem hiding this comment.
Why did you add 'scatter-like' here?
There was a problem hiding this comment.
I see, you're using traceIs(trace, 'scatter-like') in your tests. A quick grep reveals that 'scatter-like' is only used in two places, in modebar/manage.js and for some restyle call. Adding it to scatter3d won't break anything and is arguably the thing to do, so I'm 👌 with this.
|
Awesome PR @antoinerg !! 💃 💃 💃 - let's get the 1.50.0 🚋 up and running! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially closes #3816 by adding
textemplatesupport to traces withtextinfo:plus:
as well as GL traces:
Also introduced in this PR is the ability to format dates in both
(hover|text)templatevia pipe|(c6370d9 and 836d5a2).TODO:
funnelandwaterfall(db87e62)(text|hover)templateAttrsinto a single file (4ef8392)gl2dtexttemplateString(done in cbbcfcb)customdatavariable available in texttemplate (e0bde45)templateFormatString(ee0a309)textinfowhentexttemplate(9330290)metais available withintexttemplate(e7c034a)