Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar 2.0 #2200

Merged
merged 73 commits into from
Jan 16, 2018
Merged

Polar 2.0 #2200

Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
58d53e8
move (old) polar code to legacy/ folder
etpinard Nov 20, 2017
853581e
introduce scatterpolar attributes
etpinard Dec 11, 2017
3c8ae5b
introduce polar subplot attributes
etpinard Dec 11, 2017
ca8081b
introduce angles helper module
etpinard Dec 11, 2017
46fe066
first cut polar subplot defaults and draw routines
etpinard Dec 11, 2017
0826ee7
first cut scatterpolar calc/defaults/plot/style/hover
etpinard Dec 11, 2017
9770f2c
misc things to get scatterpolar traces to show up
etpinard Dec 11, 2017
0b85af2
init categories stashes for polar axes
etpinard Dec 11, 2017
cbf19c1
allow ticksuffix dflt to be passed via option
etpinard Dec 11, 2017
86204a6
get polar axis updates to work
etpinard Dec 11, 2017
0027f53
add legacy deprecation warnings
etpinard Dec 11, 2017
4cdc301
remove obsolete check for polar in registry
etpinard Dec 11, 2017
a5a719c
get snapshot redraw function right for (new) polar
etpinard Dec 11, 2017
da720aa
improve scatterpolar hover
etpinard Dec 11, 2017
04a886b
use subplot ref in scatterternary hover pointData
etpinard Dec 11, 2017
22cf4ba
expose a few things out of cartesian dragbox for :recycle:
etpinard Dec 11, 2017
122dd0b
uber wip polar main drag interaction
etpinard Dec 11, 2017
689414c
add radial axis drag interactions
etpinard Dec 11, 2017
543b615
first cut polar mocks!
etpinard Dec 11, 2017
54b3f1c
Merge branch 'master' into polar
etpinard Dec 15, 2017
17503cb
make scatter{ternary,polar,carpet} Scatter.style reuse straight-up
etpinard Dec 14, 2017
7b0f718
add test for commit 86204a6 (ternary ax tickfont relayouts)
etpinard Dec 14, 2017
fbea869
:palm_tree: domain attributes
etpinard Dec 14, 2017
1e769f0
make non-zero radialaxis.range[0] work
etpinard Dec 14, 2017
f53495e
make radial/angular axis visible: false cases work
etpinard Dec 14, 2017
c5a3a72
1st pass isPtWithinSector algo
etpinard Dec 15, 2017
61e155c
warn -> log for polar deprecation
etpinard Dec 15, 2017
258600d
:hocho: special polygon logic from scatterpolar/plot
etpinard Dec 18, 2017
0a41da5
implement {angular,radial}axis.layer
etpinard Dec 18, 2017
f3a2379
:palm_tree: make filter-visible work for calcdata containers
etpinard Dec 19, 2017
3f5e77b
first cut radial axis drag intractions
etpinard Dec 19, 2017
65b717d
get `polar.sector` working on category angular axes
etpinard Dec 19, 2017
13568a3
fixup isPtWithinSector
etpinard Dec 20, 2017
797fec1
add support for 'log' radial axes
etpinard Dec 20, 2017
0a9278c
fixup axis autotype logic for visible: false traces
etpinard Dec 22, 2017
07a3af7
make sure that angular setting relayout call propagate to tick labels
etpinard Dec 22, 2017
a263c1c
solid zoombox try + some pan work and radial drag fixups
etpinard Dec 22, 2017
765d2b7
pretty solid zoom/pan interactions
etpinard Dec 23, 2017
909d134
make polar ticks relayout more robust
etpinard Dec 27, 2017
3e1e4dd
:palm_tree: calcMarkerSize logic
etpinard Dec 28, 2017
a96131d
fix hoveron fill hover label placement edge case
etpinard Dec 28, 2017
b35d7ec
update ticks when panning sectors using new wrap180 routine
etpinard Dec 28, 2017
5751de5
make marker.size bump radial autorange results
etpinard Dec 28, 2017
86067a6
:palm_tree: cartesian/ternary/polar line/grid default logic
etpinard Dec 29, 2017
5422da9
coerce 'cliponaxis' only when markers and/or text are present
etpinard Dec 29, 2017
b4af46f
clear ternary axis titles when ternary subplots are removed
etpinard Jan 3, 2018
20b17e5
set radialaxis.rangemode dflt to 'tozero' + add support for -ve r ranges
etpinard Jan 4, 2018
cb78d19
implement radialaxis.title
etpinard Jan 4, 2018
25b4e7b
even more robust relayout
etpinard Jan 4, 2018
1e81039
large commit of attribute name & dflt changes
etpinard Jan 4, 2018
e5d238d
remove crispEdges for all polar subplot paths
etpinard Jan 4, 2018
0146c2f
Merge branch 'master' into polar
etpinard Jan 4, 2018
c94423b
adapt polar to clean-subplots improvements
etpinard Jan 4, 2018
4d5a1bd
fixups for domain attrs
etpinard Jan 10, 2018
d4c7d2c
default *rotation* to 90 for clockwise *direction*
etpinard Jan 10, 2018
8b4c2b5
do not implement 'date' angular axes (for now)
etpinard Jan 10, 2018
5357501
clear polar radial range viewInitial during log <-> linear relayout
etpinard Jan 10, 2018
9a71ba3
set limit of 100 for num2frac denominator
etpinard Jan 10, 2018
f714449
extend line & fills to polar center when pts < radialaxis.range[0]
etpinard Jan 10, 2018
cde7369
fixup radial axis drag rotate logic
etpinard Jan 10, 2018
9c4c9bf
Merge branch 'master' into polar
etpinard Jan 11, 2018
b365374
more strict check for polar subplot existence
etpinard Jan 11, 2018
a72ce55
adapt polar main drag to dragElement updates (+ tests)
etpinard Jan 11, 2018
473643c
AJ-proof latest additions
etpinard Jan 12, 2018
c2da23e
replace dragmode: 'pan' with annulus-shaped dragger
etpinard Jan 11, 2018
974740b
improve zoom dragbox behavior
etpinard Jan 11, 2018
e8aec86
un-rotate markers and text pts during angular drag
etpinard Jan 12, 2018
e8865bc
add scatterpolar hover label tests
etpinard Dec 22, 2017
8a33b89
add scatterpolar select test
etpinard Jan 12, 2018
c7a7f59
add polar drag interaction tests
etpinard Jan 15, 2018
7f7193d
a few small tweaks
etpinard Jan 15, 2018
816be51
misc. polar fixup after AJ's review:
etpinard Jan 16, 2018
18a3a0d
add clampFn option to dragElement & use it for radial drag box
etpinard Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,7 +1905,7 @@ axes.doTicks = function(gd, axid, skipTitle) {
var axLetter = axid.charAt(0),
counterLetter = axes.counterLetter(axid),
vals = axes.calcTicks(ax),
datafn = function(d) { return [d.text, d.x, ax.mirror].join('_'); },
datafn = function(d) { return [d.text, d.x, ax.mirror, d.font, d.fontSize, d.fontColor].join('_'); },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartesian axes use a special ticks update pathway that.

This here gets Axes.doTicks to update properly. I'm pretty sure some axis style updates are currently broken for ternary subplots. I'll lock those down in tests soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 in 7b0f718

tcls = axid + 'tick',
gcls = axid + 'grid',
zcls = axid + 'zl',
Expand Down Expand Up @@ -2395,6 +2395,7 @@ axes.doTicks = function(gd, axid, skipTitle) {
grid.attr('transform', transfn)
.call(Color.stroke, ax.gridcolor || '#ddd')
.style('stroke-width', gridWidth + 'px');
if(typeof gridpath === 'function') grid.attr('d', gridpath);
grid.exit().remove();

// zero line
Expand Down