Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with sunburst plot with total values #4232

Closed
archmoj opened this issue Sep 28, 2019 · 1 comment · Fixed by #4253
Closed

Problem with sunburst plot with total values #4232

archmoj opened this issue Sep 28, 2019 · 1 comment · Fixed by #4253
Assignees
@etpinard
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented Sep 28, 2019

This sunburst codepen does not show up and throws error in the console.
Also to mention - the treemap variation works fine on master.
@archmoj archmoj added the bug something broken label Sep 28, 2019
@etpinard
Copy link
Contributor

etpinard commented Oct 3, 2019

Nice catch. The same happens when generating an "implied root":

Plotly.newPlot(gd, { 
    data: [{
        type: 'sunburst',
        branchvalues: 'total',
        labels: [ 'A', 'B', 'b'],
        parents: ['Root', 'Root', 'B'],
        values: [1, 2, 1]
    }]
});

https://codepen.io/etpinard/pen/mddbBdy?editors=0010

@etpinard etpinard self-assigned this Oct 3, 2019
etpinard added a commit that referenced this issue Oct 3, 2019
@etpinard
fix #4232 - fill in value for generated sectors
02ac702 
... with the partialSum to compute the correct partition under
    `branchvalues: 'total'`. Remember, we "generate" sectors
    for "implied root" and "root of roots" scenarios.
@etpinard etpinard mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix branchvalues:total for generated sunburst/treemap sectors plotly/plotly.js
2 participants
@etpinard @archmoj