Merge pull request #5878 from 3dcl/promiseError-undefined

removed invalid .then call using lib.promiseError which does not exis…
plotly · Aug 5, 2021 · 9c06996 · 9c06996
2 parents e27ca3c + 1fa7b34
commit 9c06996
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/draftlogs/5878_fix.md b/draftlogs/5878_fix.md
@@ -0,0 +1,2 @@
+ - Fix invalid call to `lib.promiseError` in lib.syncOrAsync  [[#5878](https://github.com/plotly/plotly.js/pull/5878)], 
+   with thanks to @jklimke for the contribution!
diff --git a/src/lib/index.js b/src/lib/index.js
@@ -455,8 +455,7 @@ lib.syncOrAsync = function(sequence, arg, finalStep) {
         ret = fni(arg);
 
         if(ret && ret.then) {
-            return ret.then(continueAsync)
-                .then(undefined, lib.promiseError);
+            return ret.then(continueAsync);
         }
     }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- Fix invalid call to `lib.promiseError` in lib.syncOrAsync [[#5878](https://github.com/plotly/plotly.js/pull/5878)],
		with thanks to @jklimke for the contribution!