remove obsolete 'line' relinkColorAttrs block

- 'line' is now declared within _module.colorbar, so we don't need this block - add scatter3d test for good measure
plotly · Apr 24, 2019 · 5e7ed27 · 5e7ed27
1 parent eb7fe0f
commit 5e7ed27
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/components/colorscale/cross_trace_defaults.js b/src/components/colorscale/cross_trace_defaults.js
@@ -65,12 +65,5 @@ module.exports = function crossTraceDefaults(fullData) {
             });
         }
 
-        if(hasColorscale(trace, 'line')) {
-            relinkColorAtts(trace, {
-                container: 'line',
-                min: 'cmin',
-                max: 'cmax'
-            });
-        }
     }
 };
diff --git a/test/jasmine/tests/colorscale_test.js b/test/jasmine/tests/colorscale_test.js
@@ -910,11 +910,14 @@ describe('Test colorscale restyle calls:', function() {
             x: [1, 2, 3],
             y: [1, 2, 3],
             z: [1, 2, 1],
-            marker: {color: [1, 2, 1], showscale: true}
+            marker: {color: [1, 2, 1], showscale: true},
+            line: {color: [2, 3, 4], showscale: true}
         }])
         .then(function() {
             expect(gd._fullData[0].marker.cmin).toBe(1);
             expect(gd._fullData[0].marker.cmax).toBe(2);
+            expect(gd._fullData[0].line.cmin).toBe(2);
+            expect(gd._fullData[0].line.cmax).toBe(4);
         })
         .then(function() {
             // some non-calc edit
@@ -923,6 +926,8 @@ describe('Test colorscale restyle calls:', function() {
         .then(function() {
             expect(gd._fullData[0].marker.cmin).toBe(1);
             expect(gd._fullData[0].marker.cmax).toBe(2);
+            expect(gd._fullData[0].line.cmin).toBe(2);
+            expect(gd._fullData[0].line.cmax).toBe(4);
         })
         .catch(failTest)
         .then(done);