Merge pull request #4442 from plotly/almost-equal-branchvalues-total

Add ALMOST_EQUAL tolerance in branchvalue:total partial sum check
plotly · Dec 27, 2019 · 26541c3 · 26541c3
2 parents 4137ed2 + 08aa81b
commit 26541c3
Show file tree

Hide file tree

Showing 3 changed files with 425 additions and 1 deletion.
diff --git a/src/traces/sunburst/calc.js b/src/traces/sunburst/calc.js
@@ -17,6 +17,8 @@ var makePullColorFn = require('../pie/calc').makePullColorFn;
 var generateExtendedColors = require('../pie/calc').generateExtendedColors;
 var colorscaleCalc = require('../../components/colorscale').calc;
 
+var ALMOST_EQUAL = require('../../constants/numerical').ALMOST_EQUAL;
+
 var sunburstExtendedColorWays = {};
 var treemapExtendedColorWays = {};
 
@@ -165,7 +167,7 @@ exports.calc = function(gd, trace) {
                             v = partialSum;
                         }
 
-                        if(v < partialSum) {
+                        if(v < partialSum * ALMOST_EQUAL) {
                             failed = true;
                             return Lib.warn([
                                 'Total value for node', d.data.data.id,

diff --git a/test/image/baselines/sunburst_branchvalues-total-almost-equal.png b/test/image/baselines/sunburst_branchvalues-total-almost-equal.png