Skip to content

Commit

Permalink
Merge pull request #3180 from plotly/issue-2871
Browse files Browse the repository at this point in the history
Fixed issue #2871 - Improved text alignments in scatter3d namely right, top and bottom adjustments
  • Loading branch information
archmoj authored Oct 30, 2018
2 parents cde1f10 + 1a3bd83 commit 0124828
Show file tree
Hide file tree
Showing 7 changed files with 60 additions and 25 deletions.
34 changes: 10 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"gl-plot2d": "^1.3.1",
"gl-plot3d": "^1.5.10",
"gl-pointcloud2d": "^1.0.1",
"gl-scatter3d": "^1.0.13",
"gl-scatter3d": "^1.0.14",
"gl-select-box": "^1.0.2",
"gl-spikes2d": "^1.0.1",
"gl-streamtube3d": "^1.1.0",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_scatter3d-blank-text.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_text-weirdness.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
49 changes: 49 additions & 0 deletions test/image/mocks/gl3d_scatter3d-align-texts.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"data": [
{
"x": [3],
"y": [0],
"z": [2],
"text": ["top"],
"type": "scatter3d",
"mode":"markers+text",
"textposition": "top center"
}, {
"x": [0],
"y": [0],
"z": [0],
"text": ["left"],
"type": "scatter3d",
"mode":"markers+text",
"textposition": "center left"
}, {
"x": [1],
"y": [0],
"z": [1],
"text": ["right"],
"type": "scatter3d",
"mode":"markers+text",
"textposition": "center right"
}, {
"x": [2],
"y": [0],
"z": [0],
"text": ["bottom"],
"type": "scatter3d",
"mode":"markers+text",
"textposition": "bottom center"
}
],
"layout": {
"title":"Texts in scatter3d should be aligned to left, right, top or bottom & displayed well on WEBGL",
"width": 800,
"height": 600,
"scene":{
"camera":{
"eye":{"x":-1.25,"y":1.25,"z":1.25},
"center":{"x":0,"y":0,"z":0},
"up":{"x":0,"y":0,"z":1}
}
}
}
}

0 comments on commit 0124828

Please sign in to comment.