🔪 simplify code, just call file_ext instead

plotly · Mar 5, 2019 · 8da24be · 8da24be
1 parent 1bbd09d
commit 8da24be
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -421,12 +421,8 @@ get_package_mapping <- function(script_name, url_package, dependencies) {
 }
 
 get_mimetype <- function(filename) {
-  # the next two lines are borrowed from file_ext
-  last_dot_pos <- regexpr("\\.([[:alnum:]]+)$", filename)
-  file_ext <- ifelse(last_dot_pos > -1L, 
-                     substring(filename, 
-                               last_dot_pos + 1L), 
-                     "")
+  # the tools package is available to all
+  filename_ext <- tools::file_ext(filename)
 
   if (file_ext == 'js')
     return('application/JavaScript')