Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropTypes.function isn't a thing #864

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Conversation

alexcjohnson
Copy link
Collaborator

Surprised that this hasn't bitten us in some way... but one of our clients reported a console warning:

Warning: Failed prop type: DebugMenu: prop type `resolveError` is invalid;
it must be a function, usually from the `prop-types` package, but received `undefined`

Dunno why we don't see that same warning... though I think we would see it in component code, at least I know I've made this exact mistake before and somehow knew to correct it.

Copy link
Contributor

@byronz byronz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit d9ddc87 into master Aug 14, 2019
@alexcjohnson alexcjohnson deleted the proptypes-usage-typo branch August 14, 2019 17:32
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants