Fix documentation bug which omits children from R help pages #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,8 @@ | |||
| Version: {package_version} | |||
| Authors @R: as.person(c({package_author})) | |||
| Description: {package_description} | |||
| Depends: R (>= 3.5.0) | |||
| Depends: R (>= 3.0.2) | |||
| Imports: dashR | |||
There was a problem hiding this comment.
We talked on Friday about separating dependency loading from the Imports: dashR search, in part by extending the function name to .{package_name}_dashR_js_metadata(). That said it does seem like Imports: dashR is appropriate for its regular purpose (ensuring the right packages are installed), particularly for packages outside the core.
chriddyp
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments and usage for components in
dashHtmlComponentsanddashCoreComponentsdid not properly listchildrenin the list of supported arguments.This PR will update the 'transpiler' to address this issue, while removing references to
htmltools, and an unnecessary repeated call toreorder_props. A dependency on thedashRpackage is introduced for 'transpiled' component libraries.