Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure ci for python 3.10 #2734

Merged
merged 11 commits into from
Feb 6, 2024
Merged

configure ci for python 3.10 #2734

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
541d4b7
configure ci for python 3.10
graingert-coef Jan 30, 2024
78de5bb
add 3.10 to trove classifiers
graingert-coef Jan 30, 2024
f508435
add changelog
graingert-coef Jan 31, 2024
3a00a76
remove check for npm logs
graingert-coef Jan 31, 2024
ba17f55
Merge branch 'dev' into python-310
graingert-coef Jan 31, 2024
6129403
replace all uses of python39 with python310
graingert-coef Jan 31, 2024
01a4d97
fix changelog
graingert-coef Jan 31, 2024
e1a3c42
Merge branch 'dev' of github.com:plotly/dash into python-310
graingert-coef Feb 6, 2024
c1f0ede
update changelog with unreleased section
graingert-coef Feb 6, 2024
7ab720f
hardcode python version in snapshot name
graingert-coef Feb 6, 2024
bc1a8d3
display npm logs
graingert-coef Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dash/testing/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ def percy_snapshot(
"""
if widths is None:
widths = [1280]
snapshot_name = f"{name} - py{sys.version_info.major}.{sys.version_info.minor}"

# py3.9 hardcoded here to keep snapshot names the same accorss
# future python upgrades
snapshot_name = f"{name} - py3.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's a good strategy - this means we know what changes if any the rest of the changes in this PR cause in the percy snapshots. After merging we can make another PR to remove the version number entirely, which will cause all the snapshots to look new but we can blindly approve.

logger.info("taking snapshot name => %s", snapshot_name)
try:
if wait_for_callbacks:
Expand Down