Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ansi2html. #2721

Merged
merged 5 commits into from
Jan 9, 2024
+7 −25
Merged

Remove ansi2html. #2721

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bbd493
Remove ansi2html.
T4rk1n Jan 8, 2024
70a651b
Lock mimesis<=11.1.0
T4rk1n Jan 8, 2024
cc62bb8
Update changelog
T4rk1n Jan 9, 2024
baa9a6d
Use NoColor Ipython formatted stacktrace.
T4rk1n Jan 9, 2024
0ebc553
build
T4rk1n Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## Changed
- [#2652](https://github.com/plotly/dash/pull/2652) dcc.Clipboard supports htm_content and triggers a copy to clipboard when n_clicks are changed
- [#2721](https://github.com/plotly/dash/pull/2721) Remove ansi2html, fixes [#2613](https://github.com/plotly/dash/issues/2713)

## [2.14.2] - 2023-11-27

Expand Down
18 changes: 1 addition & 17 deletions dash/_jupyter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import os
import queue
import uuid
import re
import sys
import threading
import time
Expand All @@ -22,7 +21,6 @@
from IPython.core.display import HTML
from IPython.core.ultratb import FormattedTB
from retrying import retry
from ansi2html import Ansi2HTMLConverter
from ipykernel.comm import Comm
import nest_asyncio

Expand Down Expand Up @@ -471,21 +469,7 @@ def _wrap_errors(error):
if self.inline_exceptions:
print(ansi_stacktrace)

# Use ansi2html to convert the colored ANSI string to HTML
conv = Ansi2HTMLConverter(scheme="ansi2html", dark_bg=False)
html_str = conv.convert(ansi_stacktrace)

# Set width to fit 75-character wide stack trace and font to a size the
# won't require a horizontal scroll bar
html_str = html_str.replace(
"<html>", '<html style="width: 75ch; font-size: 0.86em">'
)

# Remove explicit background color so Dash dev-tools can set background
# color
html_str = re.sub("background-color:[^;]+;", "", html_str)

return html_str, 500
return ansi_stacktrace, 500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the comment above:

# Use IPython traceback formatting to build colored ANSI traceback
# string

Is no longer true for some reason? Does worry me a little that maybe in some cases the color will creep in and lead to ugly junk in the output. I wonder if instead of FormattedTB we could use something simpler like traceback.format_exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I didn't see the color, without dev_tools_prune_errors=False I only had one line and the color was dark red, in the devtools error had the escaped ansi symbols.

There is a NoColor mode that should do.


@property
def active(self):
Expand Down
2 changes: 1 addition & 1 deletion requires-ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ flake8==3.9.2
flaky==3.7.0
flask-talisman==1.0.0
isort==4.3.21;python_version<"3.7"
mimesis
mimesis<=11.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NBD since this is only in requires-ci, but why is this lock needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version introduced a union type like str | int and that is only supported in recent python versions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK yeah weird:

To work with Mimesis on Python versions 3.8 and 3.9, the final compatible version is Mimesis 11.1.0. Install this specific version to ensure compatibility.

but even v12.1.0 says

Requires: Python >=3.8, <4.0

Wonder why they didn't just bake that first statement into the python_requires 🤔

mock==4.0.3
numpy<=1.25.2
orjson==3.5.4;python_version<"3.7"
Expand Down
1 change: 0 additions & 1 deletion requires-install.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ contextvars==2.4;python_version<"3.7"
typing_extensions>=4.1.1
requests
retrying
ansi2html
nest-asyncio
setuptools