Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use single quotes #173

Merged
merged 3 commits into from
Dec 1, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ by this anymore :tada:
- `app.config` is now a `dict` instead of a class. You can set config variables with
`app.config['suppress_callback_exceptions'] = True` now. The previous class-based
syntax (e.g. `app.config.suppress_callback_exceptions`) has been maintained for
backwards compatability
backwards compatibility

## Fixed
- 0.18.2 introduced a bug that removed the ability for dash to serve the app on
Expand All @@ -23,8 +23,8 @@ by this anymore :tada:
These variables would be shared across apps. This issue has been fixed.
Originally reported in https://community.plot.ly/t/flask-endpoint-error/5691/7
- The config setting `supress_callback_exceptions` has been renamed to
`suppress_callback_exceptions`. Previouslly, `suppress` was spelled wrong.
The original config variable is kept for backwards compatability.
`suppress_callback_exceptions`. Previously, `suppress` was spelled wrong.
The original config variable is kept for backwards compatibility.

# 0.18.3rc1 - 2017-09-08
The prerelease for 0.18.3
Expand Down Expand Up @@ -54,7 +54,7 @@ The prerelease for 0.18.3

##🔧 Maintenance
- 📝 Update README.md
- ✅ Fix CircleCI tests. Note that the the [`dash-renderer`](https://github.com/plotly/dash-renderer) contains the bulk of the integration tests.
- ✅ Fix CircleCI tests. Note that the [`dash-renderer`](https://github.com/plotly/dash-renderer) contains the bulk of the integration tests.
- 💄 Flake8 fixes and tests (fixes #99 )
- ✨ Added this CHANGELOG.md

Expand Down
1 change: 1 addition & 0 deletions dash/_utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
class AttributeDict(dict):
"""
Dictionary subclass enabling attribute lookup/assignment of keys/values.

For example::
>>> m = AttributeDict({'foo': 'bar'})
>>> m.foo
Expand Down
2 changes: 1 addition & 1 deletion dash/development/base_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def __repr__(self):
parse_events(props),
description
)
events = "[" + ', '.join(parse_events(props)) + "]"
events = '[' + ', '.join(parse_events(props)) + ']'
if 'children' in props:
default_argtext = 'children=None, **kwargs'
argtext = 'children=children, **kwargs'
Expand Down
16 changes: 8 additions & 8 deletions tests/test_react.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def setUp(self):

self.maxDiff = 100*1000

@unittest.skip("")
@unittest.skip('')
def test_route_list(self):
urls = [rule.rule for rule in self.app.server.url_map.iter_rules()]

Expand All @@ -54,7 +54,7 @@ def test_route_list(self):
])
)

@unittest.skip("")
@unittest.skip('')
def test_initialize_route(self):
response = self.client.get('/initialize')
self.assertEqual(response.status_code, 200)
Expand All @@ -65,7 +65,7 @@ def test_initialize_route(self):
)
)

@unittest.skip("")
@unittest.skip('')
def test_dependencies_route(self):
self.app.callback('header', ['id1'])
response = self.client.get('/dependencies')
Expand Down Expand Up @@ -119,12 +119,12 @@ def test_dependencies_route(self):
}
)

@unittest.skip("")
@unittest.skip('')
def test_index_html(self):
response = self.client.get('/')
self.assertEqual(response.status_code, 200)

@unittest.skip("")
@unittest.skip('')
def test_single_observer_returning_a_dict(self):
@self.app.callback('header', ['id1'])
def update_header(input1):
Expand Down Expand Up @@ -174,7 +174,7 @@ def update_header(input1):
}
)

@unittest.skip("")
@unittest.skip('')
def test_single_observer_returning_a_component(self):
@self.app.callback('header', ['id1'])
def update_header(input1):
Expand Down Expand Up @@ -222,7 +222,7 @@ def update_header(input1):
}
)

@unittest.skip("")
@unittest.skip('')
def test_single_observer_updating_component_that_doesnt_exist(self):
# It's possible to register callbacks for components that don't
# exist in the initial layout because users could add them as
Expand Down Expand Up @@ -271,7 +271,7 @@ def update_header(input1):
}
)

@unittest.skip("")
@unittest.skip('')
def test_single_observer_with_multiple_controllers(self):
@self.app.callback('header', ['id1', 'id2'])
def update_header(input1, input2):
Expand Down
6 changes: 3 additions & 3 deletions tests/test_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,14 @@ def resource_test(self, css_or_js):

resources.config.serve_locally = True
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter("always")
warnings.simplefilter('always')
if css_or_js == 'css':
self.assertEqual(
resources.get_all_css(),
expected_filtered_relative_resources
)
assert len(w) == 1
assert "A local version of {} is not available".format(
assert 'A local version of {} is not available'.format(
extra_resource['external_url']
) in str(w[-1].message)

Expand All @@ -151,7 +151,7 @@ def resource_test(self, css_or_js):
expected_filtered_relative_resources
)
assert len(w) == 1
assert "A local version of {} is not available".format(
assert 'A local version of {} is not available'.format(
extra_resource['external_url']
) in str(w[-1].message)

Expand Down