-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always sort prop_ names
#107
Conversation
It's hard to find the property you want in the unsorted dict key so always sort the names before printing them
This is great. I agree that we should sort the properties on errors. However, I'm not sure if we should sort them in general: The component authors might order the properties in their own perceived "order of importance". For example, the
I'll update this PR to just sort the names on errors for now. |
For particular components, we can update their order in the source code of the component itself, either dash-core-components or dash-html-components |
It's hard to find the property you want in the unsorted dict key so always sort the names before printing them. E.g.
rel
is not in the place I would expect here - I expected it beforespellCheck
: