Merge pull request #2700 from plotly/fix/dynamic-callback-inputmap

Fix dynamic callbacks reset graphs.
plotly · Nov 27, 2023 · 913cb52 · 913cb52
2 parents 3adb9a9 + f044276
commit 913cb52
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 3 deletions.
diff --git a/dash/dash-renderer/src/APIController.react.js b/dash/dash-renderer/src/APIController.react.js
@@ -166,7 +166,7 @@ function storeEffect(props, events, setErrorLoading) {
             );
         } else if (
             dependenciesRequest.status === STATUS.OK &&
-            isEmpty(graphs)
+            (isEmpty(graphs) || graphs.reset)
         ) {
             dispatch(
                 setGraphs(

diff --git a/dash/dash-renderer/src/actions/requestDependencies.ts b/dash/dash-renderer/src/actions/requestDependencies.ts
@@ -3,9 +3,10 @@ import {setGraphs} from './index';
 import apiThunk from './api';
 
 export function requestDependencies() {
-    return (dispatch: any) => {
+    return (dispatch: any, getState: any) => {
         batch(() => {
-            dispatch(setGraphs({}));
+            const {graphs} = getState();
+            dispatch(setGraphs({...graphs, reset: true}));
             dispatch(
                 apiThunk('_dash-dependencies', 'GET', 'dependenciesRequest')
             );

diff --git a/tests/integration/callbacks/test_dynamic_callback.py b/tests/integration/callbacks/test_dynamic_callback.py
@@ -42,3 +42,34 @@ def on_click2(n_clicks2):
 
     dash_duo.wait_for_element("#dynamic").click()
     dash_duo.wait_for_text_to_equal("#output-2", "Dynamic clicks 2")
+
+
+def test_dync002_dynamic_callback_without_element(dash_duo):
+    app = Dash()
+
+    app.layout = html.Div(
+        [
+            html.Button("Add callbacks", id="add-callbacks"),
+            html.Div(id="output"),
+        ]
+    )
+
+    @app.callback(
+        Output("output", "children"),
+        Input("add-callbacks", "n_clicks"),
+        _allow_dynamic_callbacks=True,
+        prevent_initial_call=True,
+    )
+    def on_add_callback(_):
+        @app.callback(Output("no-exist", "children"), Input("invalid", "n_clicks"))
+        def addition(_):
+            return "additional"
+
+        return html.Div("add callbacks")
+
+    dash_duo.start_server(app)
+
+    dash_duo.wait_for_element("#add-callbacks").click()
+    dash_duo.wait_for_text_to_equal("#output", "add callbacks")
+
+    assert dash_duo.get_logs() == []