204 NO CONTENT regression fix (#170)

plotly · May 10, 2019 · 4744414 · 4744414
1 parent e2a1707
commit 4744414
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Fixed
+- Fix regression on handling PreventUpdate (204 NO CONTENT) [#170](https://github.com/plotly/dash-renderer/pull/170)
+
 ## [0.23.0] - 2019-04-25
 ### Fixed
 - Fix regression for `children=0` case [#148](https://github.com/plotly/dash-renderer/issues/148)

diff --git a/src/actions/index.js b/src/actions/index.js
@@ -674,13 +674,18 @@ function updateOutput(
                 // update the status of this request
                 updateRequestQueue(true, res.status);
 
+                /*
+                 * This is a 204 response code, there's no content to process.
+                 */
+                if (res.status === STATUS.PREVENT_UPDATE) {
+                    return;
+                }
+
                 /*
                  * eject into `catch` handler below to display error
                  * message in ui
                  */
-                if (res.status !== STATUS.PREVENT_UPDATE) {
-                    throw res;
-                }
+                throw res;
             }
 
             /*

diff --git a/tests/test_render.py b/tests/test_render.py
@@ -329,7 +329,7 @@ def update_input(value):
             'lxml').select_one('#output > div').contents
 
         self.assertTrue(
-            pad_input.attrs == {'id': 'sub-input-1', 'value': 'sub input initial value'}
+            pad_input.attrs == {'type': 'text', 'id': 'sub-input-1', 'value': 'sub input initial value'}
                 and pad_input.name == 'input',
             "pad input is correctly rendered")