Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Issue 489 - content_style regression #501

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Issue 489 - content_style regression #501

merged 4 commits into from
Jul 15, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Jul 15, 2019 •
edited
Loading

Fixes #489 and improves the nomenclature.

  • Undo the regression introduced by removing content_style in Refactor table API #446

  • Rename the prop fill_width with now type boolean (True=grow, False=fit in previous prop)

  • Add back the flags for the modified tests

  • Changelog entry

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-501 July 15, 2019 16:05 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title 489 content style Issue 489 - content_style regression Jul 15, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review July 15, 2019 16:19
alexcjohnson
alexcjohnson approved these changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 5571f7a into master Jul 15, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 489-content-style branch July 15, 2019 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datatable fail to expand horizontally after 4.0.0 upgrade
3 participants
@Marc-Andre-Rivet @alexcjohnson @chriddyp