Bugfix remove query string inclusion in body class generation logic #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
Need Review @stevepiercy @Wagner3UB @sneridagh |
stevepiercy
requested changes
Dec 19, 2024
Co-authored-by: Steve Piercy <web@stevepiercy.com>
e3d1b84 to
93cbb0f
Compare
stevepiercy
approved these changes
Dec 19, 2024
|
@stevepiercy Glad to hear that! Let me know if there's anything else needed. |
giuliaghisini
approved these changes
Dec 19, 2024
davisagli
reviewed
Dec 19, 2024
sneridagh
added a commit
that referenced
this pull request
Jan 10, 2025
* main: Slate Italian translations (#6563) Release 18.5.0 Fix robots.txt in devmode (#6571) added swedish translation (#6557) Depth search issue (#6558) Block examples documentation (#6560) Fixed folder contents issues with persistent selection (#6554) Fix redirects to MDN responsive images (#6552) Bugfix remove query string inclusion in body class generation logic (#6547) Show related items (#4381) Update links to kitconcept.com Release 18.4.0 Release @plone/components 3.0.1 Release @plone/types 1.2.0 Fix precedence of the quanta layer by adding a base layer for all the… (#6539) Add monorepo structure to the README (#6542)
sneridagh
added a commit
that referenced
this pull request
Jan 21, 2025
* main: (741 commits) Improve the usability of the ObjectBrowser when inputting a manual value, checking it on blur, and adding a local validator (#6576) fixing Markdown heading (#6588) fix site logo issue (#6591) Route registry (#6600) Release @plone/client 1.0.0-alpha.21 Export the getContent bare fetcher (#6594) fix: incorrect copied state useClipboard (#6585) [RR7] Update to latest RR7 and conventions, fix index page (#6589) Release 18.6.0 Release @plone/slate 18.1.0 Revert "added swedish translation" (#6578) Slate Italian translations (#6563) Release 18.5.0 Fix robots.txt in devmode (#6571) added swedish translation (#6557) Depth search issue (#6558) Block examples documentation (#6560) Fixed folder contents issues with persistent selection (#6554) Fix redirects to MDN responsive images (#6552) Bugfix remove query string inclusion in body class generation logic (#6547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
After fix body class only include the ?type= query_string in is-adding-contenttype class. All other query strings are ignored. If there's no type, no is-adding-contenttype class will be present.
Screenshots after fixing bug:
Closes #6493