Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul environment variables documentation #5736

Merged
merged 15 commits into from
Feb 13, 2024
Merged

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Feb 6, 2024

See comment #4581 (comment)

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 72f294f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65caf55ab1a0c20008e2a38b

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 72f294f
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65caf55a9a9bcc00086f6119
😎 Deploy Preview https://deploy-preview-5736--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevepiercy
Copy link
Collaborator Author

@tiberiuichim I'd like a final review from you before merging, since this is pivotal to #4581. Preview at https://deploy-preview-5736--volto.netlify.app/configuration/environmentvariables.html

@ichim-david
Copy link
Member

@davisagli on a closer look at https://github.com/plone/volto/blob/main/packages/registry/src/addon-registry.js#L145
Is this example correct?
"You can specify profiles for installation:
ADDONS=test-addon:profile1,test-addon2:profile2 yarn start"

I have a feeling that we should replace that section with the one below that I've complained
here:
#5736 (comment)

"If you need to specify several add-ons, separate them with a semicolon (;):
yarn add volto-slate
ADDONS="volto-slate:asDefault;@kitconcept/volto-blocks-grid" yarn start"

@sneridagh sneridagh merged commit 27f3911 into main Feb 13, 2024
65 checks passed
@sneridagh sneridagh deleted the docs-env-vars-overhaul branch February 13, 2024 08:11
sneridagh added a commit that referenced this pull request Feb 15, 2024
…bars-et-al

* main: (56 commits)
  Exclude chromewebstore from linkcheck (#5761)
  (feat):App extras exceptions (#5621)
  Add VOLTOCONFIG Env Var (#5752)
  PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750)
  Update links to Redux and React developer extensions for Chrome (#5757)
  Overhaul environment variables documentation (#5736)
  Mention what version the 'links and references' view was added (#5756)
  Add wait commands to flaky block-listing tests (#5753)
  Fix logging in test-acceptance-server commands (#5748)
  Replaced outdated diff with a link to the current `package.json` on t… (#5728)
  Listing Block render of initial results in SSR (#5689)
  Fix @plone/volto-slate path in moduleNameMapper (#5743)
  Added global form state. (#5721)
  Release generate-volto 9.0.0-alpha.5
  Fix tests in projects that involves TS files (#5738)
  Reorganize README, merging content into authoritative locations (#5511)
  Release 18.0.0-alpha.10
  Release generate-volto 9.0.0-alpha.4
  Release @plone/registry 1.2.2
  Enhance release in @plone/registry
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants