-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md add another QuickLink for HowTo Suggest edit #922
Conversation
**Please** add a fourth option in the following menu and description: "HowTo Quick Link for **Suggest edit**" full Tool-Type Text: Link to our Docs for using "Suggest edit" HowTo if you have already signed a Contributor Agreement. See placeholder copy in the request. No actual code change added!
I missed to hit the draft button. Try to figure out how to set the state back. Until then this comment.
Need to find the option in the UI… lalala |
This is not possible with the theme. Sorry. |
I should mention that any and all pull requests require that the contributor either sign the PCA or post a statement, as specified in https://training.plone.org/contributing/index.html#granting-permission-to-publish. It's just not possible to do this in a menu item or in the theme. I am inclined to remove "Suggest edit" because it is intended for organizations that don't require such a thing as a PCA or copyright assignment. |
This is not my intention! I understand your frustration confronted with pull requests, that do not meet the requirements. But this is life. You have to reject them unless you get some from e.g. me (who signed this). But you need to check it anyway. It is two sided sword. Either:
We already discussed this. Heads up. I keep kicking. |
The content of the PR does not make sense. I interpret it as content that should be submitted as an issue, not something that should be added to the documentation. I do not understand your intent here. |
You are right. Actually it needs a PR in the Theme. |
I would prefer a PR that implements |
Please add a fourth option in the following menu and description: "HowTo Quick Link for Suggest edit"
full Tool-Type Text: Link to our Docs for using "Suggest edit" HowTo if you have already signed a Contributor Agreement.
See placeholder copy in the request. No actual code change added!
📚 Documentation preview 📚: https://plone-training--922.org.readthedocs.build/