Add the portal_url parameter to be used with Diazo rules

[yurj]

Looking at this rule, for example:

    <!-- We can't control the bundle from here due to include. Just hard code -->
    <after css:theme-children="head">
      <link href="++theme++barceloneta/css/barceloneta.css"
            rel="stylesheet"
      />
    </after>

the css will be loaded relative to the content. This is problematic:

• different url for the same css file, cache problems
• traversing private content can lead to "Insufficient privileges" while the resource itself is public

This PR add the portal_url variable in the theme parameters (manifest.cfg) and apply it in backend.xml

[mister-roboto]

@yurj thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[yurj]

@jenkins-plone-org please run jobs

[yurj]

@thet can this PR be a problem for collective.lineage? It just use the variable in backend.xml.

[yurj]

Note: Jenkins failures have nothing to do with this PR

[yurj]

@jenkins-plone-org please run jobs

[yurj]

Let's wait @petschki before merging it.

[petschki]

I thought this is automatically done when you add a starting slash to the resources in your theme template like /++theme++/... ... maybe someone can check this in plone.app.theming.

Greetings from Sardegna ☀️🏖️😅

[yurj]

I thought this is automatically done when you add a starting slash to the resources in your theme template like /++theme++/... ... maybe someone can check this in plone.app.theming.

Greetings from Sardegna ☀️🏖️😅

backend.xml haven't it (no slash in front of it). In custom themes there's no problem because they're custom. For VHM rewrited urls, portal_url should return the correct url (not / but /path/my/site/), so it should cover most of the supported cases. This PR does not use the portal_url parameter other than in backend.xml which actually is a relative link and should be fixed (different urls for the same file, traversing private content problem).

Great Sardegna! ☀️

[thet]

👍 and ❤️ for this PR!
Minor comments though - I think I'd remove the curly braces, if they are not needed.
Check that again, please.

I'm approving, so you can check my comments and apply my suggestion if applicable or otherwise just merge, if the curlys are needed.

Greetings from our Wales/England vacation :D