Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleNotFoundError: No module named 'Products.Five.browser.decode' #26

Closed
mauritsvanrees opened this issue Feb 12, 2020 · 6 comments · Fixed by #27
Closed

ModuleNotFoundError: No module named 'Products.Five.browser.decode' #26

mauritsvanrees opened this issue Feb 12, 2020 · 6 comments · Fixed by #27
Assignees
@mauritsvanrees
Labels
02 type: regression 12 prio: high 31 needs: help

Comments

@mauritsvanrees
Copy link
Member

On Plone 6 development buildout.
@mauritsvanrees mauritsvanrees self-assigned this Feb 12, 2020
@mauritsvanrees
Copy link
Member Author

See also zopefoundation/Products.GenericSetup#90

@mauritsvanrees
Copy link
Member Author

On Zope 4+ the processInputs call is no longer needed, so we can remove this.

The master branch is only used on Plone 5.2+, so that is fine.
If this branch were used on earlier Plone/Zope versions, we could do a try/except ImportError, and only apply processInputs when we can import it.

I will make a PR.

mauritsvanrees added a commit that referenced this issue Feb 12, 2020
@mauritsvanrees
Do not call processInputs.
0e67645 
It is not needed since Zope 4, and not existing in Zope 5.
Fixes #26
@mauritsvanrees mauritsvanrees mentioned this issue Feb 12, 2020
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Feb 14, 2020
@jensens
[fc] Repository: plone.resourceeditor
9f4a167 
Branch: refs/heads/master
Date: 2020-02-12T12:22:50+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.resourceeditor@0e67645

Do not call processInputs.

It is not needed since Zope 4, and not existing in Zope 5.
Fixes plone/plone.resourceeditor#26

Files changed:
A news/26.bugfix
M plone/resourceeditor/browser.py
Repository: plone.resourceeditor

Branch: refs/heads/master
Date: 2020-02-14T14:27:59+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.resourceeditor@77d128f

Merge pull request #27 from plone/maurits-zope5-compat

Do not call processInputs.

Files changed:
A news/26.bugfix
M plone/resourceeditor/browser.py
@mauritsvanrees
Copy link
Member Author

I reopen this, because maybe processInputs is needed anyway. See plone/plone.app.theming#183
I have not checked for plone.resourceeditor.

@mauritsvanrees
Copy link
Member Author

I don't know how to check that this is broken or not on Plone 5.2. I think I tried something when I reopened this, and did not get an error, but I may have tried something that has nothing to do with plone.resourceeditor.

@petschki
Copy link
Member

petschki commented Sep 9, 2021

I cannot reproduce this error in current coredev#6.0 ... I guess this is fixed now?

@mauritsvanrees
Copy link
Member Author

I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
02 type: regression 12 prio: high 31 needs: help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not call processInputs. plone/plone.resourceeditor
2 participants
@mauritsvanrees @petschki