Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the raw value of rich text fields #49

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

mauritsvanrees
Copy link
Member

This is instead of the transformed output. This fixes internal links in Classic UI based distributions. Fixes issue #48.

Sample difference in output:

<     "data": "<p>Link to <a href=\"http://nohost/Plone/news\">news</a>.</p>",
---
>     "data": "<p>Link to <a href=\"resolveuid/4053ffb6901342ac991afb54da15ab77\" data-linktype=\"internal\" data-val=\"4053ffb6901342ac991afb54da15ab77\">news</a>.</p>",

…output.

This fixes internal links in Classic UI based distributions.

Fixes #48

Sample difference in output:

```
<     "data": "<p>Link to <a href=\"http://nohost/Plone/news\">news</a>.</p>",
---
>     "data": "<p>Link to <a href=\"resolveuid/4053ffb6901342ac991afb54da15ab77\" data-linktype=\"internal\" data-val=\"4053ffb6901342ac991afb54da15ab77\">news</a>.</p>",
```
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; similar to what we do for blocks.

@mauritsvanrees mauritsvanrees merged commit ba480e3 into main Jan 31, 2025
9 of 11 checks passed
@mauritsvanrees mauritsvanrees deleted the export-richtext-raw branch January 31, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants