Include revisions only when passing --include-revisions. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
This was referenced Jan 21, 2025
Closed
Also temporarily disable versioning when creating a bare content object. Otherwise the first version is basically nothing, it does not even have a title.
591854a to
b162d77
Compare
davisagli
requested changes
Jan 22, 2025
Left-over from an earlier try.
This prevents the repository tool from being marked as changed, which is what happened with the previous code. See #44 (comment)
Done. Are the docs actually visible anywhere? I don't see a link... |
mauritsvanrees
added a commit
to plone/plone.distribution
that referenced
this pull request
Jan 22, 2025
This needs plone/plone.exportimport#44. It would be good to have that merged and in a release, so we can add that release as minimum version in our dependencies.
davisagli
approved these changes
Jan 22, 2025
No. Where should they be published, RTD only or pulled into Plone 6 Documentation as a submodule? If Plone 6 Documentation, where is a good place for them? It sounds like i/e is useful for more than just upgrades, including backups and restores. In any case, I should set up pull request previews on RTD. Please let me know. Thank you! |
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jan 23, 2025
Branch: refs/heads/main Date: 2025-01-21T22:44:12+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.exportimport@b162d77 Include revisions only when passing --include-revisions. Also temporarily disable versioning when creating a bare content object. Otherwise the first version is basically nothing, it does not even have a title. Files changed: A news/39.feature.4 M src/plone/exportimport/cli/__init__.py M src/plone/exportimport/exporters/__init__.py M src/plone/exportimport/exporters/base.py M src/plone/exportimport/exporters/content.py M src/plone/exportimport/utils/content/export_helpers.py M src/plone/exportimport/utils/content/import_helpers.py Repository: plone.exportimport Branch: refs/heads/main Date: 2025-01-22T16:29:31+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.exportimport@2fd3b78 Remove unneeded kwargs from dump. Left-over from an earlier try. Files changed: M src/plone/exportimport/exporters/content.py Repository: plone.exportimport Branch: refs/heads/main Date: 2025-01-22T16:50:09+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.exportimport@8750537 Use unittest.mock.patch to patch isVersionable to return False. This prevents the repository tool from being marked as changed, which is what happened with the previous code. See plone/plone.exportimport#44 (comment) Files changed: M src/plone/exportimport/utils/content/import_helpers.py Repository: plone.exportimport Branch: refs/heads/main Date: 2025-01-22T17:03:15+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.exportimport@3896e8b Document the new plone-exporter --include-revisions option. Files changed: M docs/features.md Repository: plone.exportimport Branch: refs/heads/main Date: 2025-01-23T16:24:09+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.exportimport@d04511e Merge pull request #44 from plone/maurits-sustainable-exports-optional-versions Include revisions only when passing --include-revisions. Files changed: A news/39.feature.4 M docs/features.md M src/plone/exportimport/cli/__init__.py M src/plone/exportimport/exporters/__init__.py M src/plone/exportimport/exporters/base.py M src/plone/exportimport/exporters/content.py M src/plone/exportimport/utils/content/export_helpers.py M src/plone/exportimport/utils/content/import_helpers.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Jan 27, 2025
Branch: refs/heads/main Date: 2025-01-22T17:21:53+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.distribution@c12ee5b Include revisions only when passing --include-revisions. This needs plone/plone.exportimport#44. It would be good to have that merged and in a release, so we can add that release as minimum version in our dependencies. Files changed: A news/39.feature M README.md M src/plone/distribution/cli/__init__.py Repository: plone.distribution Branch: refs/heads/main Date: 2025-01-23T23:26:40+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.distribution@191d265 Require plone.exportimport 1.0.0b1 as minimum. This is needed for the --include-revisions option. Files changed: M setup.py Repository: plone.distribution Branch: refs/heads/main Date: 2025-01-27T10:40:48-08:00 Author: David Glick (davisagli) <david@glicksoftware.com> Commit: plone/plone.distribution@1164162 Merge pull request #108 from plone/maurits-optional-include-versions Include revisions only when passing --include-revisions. Files changed: A news/39.feature M README.md M setup.py M src/plone/distribution/cli/__init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also temporarily disable versioning when creating a bare content object. Otherwise the first version is basically nothing, it does not even have a title.