Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add require=false to boolean fields in ISiteSyndicationSettings #14

Closed
1letter opened this issue Jun 30, 2022 · 1 comment · Fixed by #15
Closed

add require=false to boolean fields in ISiteSyndicationSettings #14

1letter opened this issue Jun 30, 2022 · 1 comment · Fixed by #15

Comments

@1letter
Copy link
Contributor

1letter commented Jun 30, 2022

without require=false the boolean field can't set to false
@1letter 1letter linked a pull request Jun 30, 2022 that will close this issue
1letter/fix#14 #15
Merged
@davisagli
Copy link
Member

There's no way to change it in a backwards-compatible way, but it's too bad that Bool fields don't default to required=False

frapell added a commit that referenced this issue Dec 23, 2022
@frapell
Add required=False to missing boolean field from syndication config…
6693557 
…. refs gh-14
@frapell frapell mentioned this issue Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1letter/fix#14 plone/plone.base
2 participants
@davisagli @1letter