Skip to content

Commit

Permalink
Merge pull request #59 from plone/plonezope4
Browse files Browse the repository at this point in the history
remove deprecated __of__ for browserviews
  • Loading branch information
jensens authored Feb 4, 2017
2 parents 356acad + 66edcfc commit 6d92326
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ New features:

Bug fixes:

- *add item here*
- remove deprecated __of__ for browserviews
[pbauer]


2.2 (2017-01-02)
Expand Down
2 changes: 1 addition & 1 deletion plone/app/z3cform/inline_validation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Let's verify that worked:
... def restrictedTraverse(self, name):
... # fake traversal to the form
... if name.startswith('@@'):
... return getMultiAdapter((self, self._REQUEST), Interface, name[2:]).__of__(self)
... return getMultiAdapter((self, self._REQUEST), Interface, name[2:])
... else:
... return getattr(self, name)
...
Expand Down

1 comment on commit 6d92326

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.z3cform/31/violations

plone/app/z3cform/inline_validation.py:15:1: C901 'InlineValidationView.__call__' is too complex (15)
plone/app/z3cform/templates.py:24:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/z3cform/tests/example.py:26:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/example.py:31:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:44:34: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:55:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:70:30: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:71:55: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:72:52: Q000 Remove bad quotes.
plone/app/z3cform/tests/example.py:77:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:21:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:26:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_objectsubform.py:46:15: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:49:19: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:57:13: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_objectsubform.py:62:15: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_widgets.py:41:5: D001 found implements( replace it with zope.interface.implementer
plone/app/z3cform/tests/test_widgets.py:1257:40: Q000 Remove bad quotes.
plone/app/z3cform/tests/test_utils.py:21:9: E731 do not assign a lambda expression, use a def
plone/app/z3cform/tests/test_widget.py:12:15: D001 found implements( replace it with zope.interface.implementer

Follow these instructions to reproduce it locally.

Please sign in to comment.