Call processInputs when available, fixing WrongType #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help surface some `WrongType` exceptions.
This reverts commit dd4f7fc.
The field is SourceText, which is unicode on Python 2, and str on Python 3. So on Python 2, creating a string of it results in a WrongType error. See #183
This reverts commit d6db78d. No longer needed after calling processInputs.
ale-rt
reviewed
Jun 10, 2020
|
Not needed: For clarity, the field with this name is still there. But the method that I remove here was only a helper method added in PR #178, one of the |
Otherwise when you upgrade from Plone 5.2.1, and try to save the theming control panel, you get an error: ``` Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 162, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 359, in publish_module Module ZPublisher.WSGIPublisher, line 262, in publish Module ZPublisher.mapply, line 85, in mapply Module ZPublisher.WSGIPublisher, line 63, in call_object Module plone.app.theming.browser.controlpanel, line 65, in __call__ Module plone.app.theming.browser.controlpanel, line 215, in update Module plone.registry.recordsproxy, line 59, in __setattr__ AttributeError: custom_css_timestamp ```
|
@jenkins-plone-org please run jobs |
|
Hurray, Jenkins is running again, and the tests are passing on all versions. |
|
Good to be merged for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #183.
I added a test that saves the advanced control panel. And I tested it manually in the browser. Tested in Plone 5.2 on Py 2 and 3, and on Plone 6. All seems well.