Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cyclic dependency with plone.app.event. #156

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

ericof
Copy link
Member

@ericof ericof commented Sep 15, 2021

Fixes #155

@ericof ericof self-assigned this Sep 15, 2021
@mister-roboto
Copy link

@ericof thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ericof
Copy link
Member Author

ericof commented Sep 15, 2021

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericof ericof merged commit 1a3c1dd into master Sep 15, 2021
@ericof ericof deleted the issue-155-remove-cyclic-dependency branch September 15, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic dependency with plone.app.event
3 participants