Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to a 4K x 4K browser window in Robot tests #523

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

Rotonen
Copy link
Contributor

@Rotonen Rotonen commented May 13, 2019

I'm in the process of trying to unify Robot test setups and teardowns. This is a part of that effort.

In tandem with plone/plone.app.robotframework#110
Closes #522

@mister-roboto
Copy link

@Rotonen thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@Rotonen Rotonen requested review from tisto and datakurre May 14, 2019 10:54
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge.

@mauritsvanrees mauritsvanrees merged commit 9e26cb6 into master Jun 14, 2019
@mauritsvanrees mauritsvanrees deleted the roto-window-resize-huge branch June 14, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Robot tests to use new shared test setups
3 participants