Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test setup by using the MOCK_MAILHOST_FIXTURE #60

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Simplify test setup by using the MOCK_MAILHOST_FIXTURE #60

merged 1 commit into from
Dec 11, 2020

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Dec 11, 2020

Fixes #59

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Dec 11, 2020

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented Dec 11, 2020

@jaroel this should fix a bunch of tests in the dx site root plip job, e.g.: https://jenkins.plone.org/view/PLIPs/job/plip-dx-siteroot-3.8/24/testReport/junit/plone.app.contentrules.tests.test_action_mail/TestMailAction/testExecute/

@jaroel
Copy link
Member

jaroel commented Dec 11, 2020

@jaroel this should fix a bunch of tests in the dx site root plip job, e.g.: https://jenkins.plone.org/view/PLIPs/job/plip-dx-siteroot-3.8/24/testReport/junit/plone.app.contentrules.tests.test_action_mail/TestMailAction/testExecute/

Hahahahahaha :D You are amazing!

jaroel
jaroel approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@jaroel jaroel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; fixed couple of tests in the DX site root branches, so seems to work!

mauritsvanrees
mauritsvanrees approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks!

@mauritsvanrees mauritsvanrees merged commit 94edd29 into master Dec 11, 2020
@mauritsvanrees mauritsvanrees deleted the 59.fixed branch December 11, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroel jaroel jaroel approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the MOCK_MAILHOST_FIXTURE instead of a custom approach
4 participants
@ale-rt @mister-roboto @jaroel @mauritsvanrees