Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit link #835

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Fix edit link #835

merged 2 commits into from
Mar 26, 2018

Conversation

davisagli
Copy link
Member

/@@edit specifies a browser view, which is not available for Archetypes content items. /edit should work more generally.

thet
thet approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although I prefer the more explicit @@ notation for views, as otherwise it's not distinguishable from attributes access or acquisition. But in this case, this doesn't matter much.

@jensens jensens merged commit 21f8830 into master Mar 26, 2018
@jensens jensens deleted the davisagli-edit-link branch March 26, 2018 13:33
@jensens
Copy link
Member

jensens commented Mar 26, 2018

I suppose resource need to be rebuild in Products.CMFPlone in order to make it effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davisagli @jensens @thet