Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix 5.2 branch #504

Closed
wants to merge 1 commit into from
Closed

Try to fix 5.2 branch #504

wants to merge 1 commit into from

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jul 12, 2018

Since a few builds one of the jenkins jobs targetting 5.2 branch is failing, my guess is that plone/plone.indexer#6 was the problem as it was merged although the 5.2 jenkins job pull request failed, was there a good reason to ignore it? @jensens

Let's see if, indeed, removing plone.indexer fixes the problem.

@jensens
Copy link
Member

jensens commented Jul 13, 2018

At time of merging it was green IIRC. Also, there were other PRs merged together with plone.indexer.

I think a side effect came in with plone.restapi, but no idea why it did not hit the PR...
here https://jenkins.plone.org/job/pull-request-5.2/962/testReport/plone.restapi.tests.test_search/TestSearchFunctional/test_full_metadata_retrieval/

The problem: Before exclude_from_nav metadata was accidentally acquired. Now it is not and the returned value is None instead of the previously acquired False.

Question here is,

  • do we want to accept the new behavior, which is telling us there was no explicit value set?
  • or do we want to register an indexer returning false on items w/o the attribute exclude_from_nav?

@jensens
Copy link
Member

jensens commented Jul 17, 2018

should be solved with plone/plone.restapi#580

@jensens jensens closed this Jul 17, 2018
@jensens jensens deleted the gforcada-patch-1 branch July 17, 2018 16:26
mister-roboto pushed a commit that referenced this pull request Feb 8, 2019
Branch: refs/heads/master
Date: 2019-02-08T15:29:58+01:00
Author: Wolfgang Thomas (pysailor) <thomas@syslab.com>
Commit: plone/plone.app.contenttypes@7359717

Declare the former dotted name of the LeadImage and the RichText behavior
Follows #480
Depends on plone/plone.behavior#19

Files changed:
M plone/app/contenttypes/behaviors/configure.zcml
Repository: plone.app.contenttypes

Branch: refs/heads/master
Date: 2019-02-08T15:34:58+01:00
Author: Wolfgang Thomas (pysailor) <thomas@syslab.com>
Commit: plone/plone.app.contenttypes@6b96b5b

update changelog

Files changed:
A news/480.bugfix
Repository: plone.app.contenttypes

Branch: refs/heads/master
Date: 2019-02-08T17:21:56+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.contenttypes@5827048

Merge pull request #504 from plone/declare-old-dotted-name

Declare the former name of the LeadImage behavior

Files changed:
A news/480.bugfix
M plone/app/contenttypes/behaviors/configure.zcml
mister-roboto pushed a commit that referenced this pull request Feb 22, 2019
Branch: refs/heads/master
Date: 2019-02-22T10:49:00+01:00
Author: Wolfgang Thomas (pysailor) <thomas@syslab.com>
Commit: plone/plone.app.contenttypes@bf12123

Declare dependency on plone.behavior and pin version
Refs #504
Fixes #508

Files changed:
M setup.py
Repository: plone.app.contenttypes

Branch: refs/heads/master
Date: 2019-02-22T15:35:27+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.contenttypes@23b334b

Merge pull request #509 from plone/508-version-pin

Declare dependency on plone.behavior and pin version

Files changed:
M setup.py
mister-roboto pushed a commit that referenced this pull request Jul 12, 2023
Branch: refs/heads/master
Date: 2023-07-13T00:06:05+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.api@f27d51b

Mockup TinyMCE settings: Remove unused AtD related views. (#504)

Fix a test which was checking for "checkDocument" among other available views.
"checkDocument" was a TinyMCE endpoint for unmaintained "After the Deadline"
plugin, which is now removed.

Files changed:
A news/504.bugfix
M src/plone/api/tests/test_content.py
mister-roboto pushed a commit that referenced this pull request Jul 12, 2023
Branch: refs/heads/master
Date: 2023-07-13T00:06:05+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.api@f27d51b

Mockup TinyMCE settings: Remove unused AtD related views. (#504)

Fix a test which was checking for "checkDocument" among other available views.
"checkDocument" was a TinyMCE endpoint for unmaintained "After the Deadline"
plugin, which is now removed.

Files changed:
A news/504.bugfix
M src/plone/api/tests/test_content.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants