Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded code from recursiveTranslate #15

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mauritsvanrees
Copy link
Member

This code broke with latest Zope 5.11.
zope.i18n already supports recursive translation out of the box since 2008.

See #14 (comment). This replaces that PR.

For testing this, I used collective.easyform. In a form I added an integer field with a RangeValidator. Then I edited the RangeValidator code to insert a random existing Message from the plone domain into the validation error. And this showed up translated in Dutch:

Screenshot 2024-12-10 at 13 54 47

…st Zope 5.11.

``zope.i18n`` already supports recursive translation out of the box since 2008.

See #14 (comment)
@mister-roboto

This comment was marked as resolved.

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 494d29a into main Dec 10, 2024
10 of 11 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-recursive-translate-simplify branch December 10, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants