Checking if a block has been cancelled immediately before it runs #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously was there because of testing
|
Sadly, I'm unable to work out how to write a unit test for this because |
| @@ -755,6 +755,10 @@ public class ConsistencyManager { | |||
| // Default to true if weakOperation is nil | |||
| return weakOperation?.cancelled ?? true | |||
| } | |||
| // Let's check here to see if it's cancelled before we start | |||
| if cancelled() { | |||
There was a problem hiding this comment.
super-minor: instead of cancelled() here, I'd put () at the end of the { } block above, so you can just say if cancelled
There was a problem hiding this comment.
Can't do that because I pass the cancelled block into the next function.
I actually need that closure.
|
lgtm after minor comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.