Enum Support #136
Merged
Enum Support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaadBazaz
requested changes
Feb 24, 2025
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs
Outdated
Show resolved
Hide resolved
- retrieves state using interop. - removed unnecessary comments.
|
Calling in the big guns. @momintlh |
|
Is this tested? @uzaiiirahmed
|
NOT YET |
momintlh
previously requested changes
Feb 26, 2025
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs
Outdated
Show resolved
Hide resolved
|
Also add ENUM support for |
- tested in Local mode - tested in Browser Bridge mode
momintlh
reviewed
Mar 1, 2025
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockPlayerService.cs
Show resolved
Hide resolved
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockPlayerService.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs
Outdated
Show resolved
Hide resolved
SaadBazaz
reviewed
Mar 3, 2025
| json = JsonUtility.ToJson(value is int or float or bool or string | ||
| ? new PrimitiveWrapper<object>(value) | ||
| : value); | ||
| if (value is int or float or bool or string) |
There was a problem hiding this comment.
Yeah always better to have clear if-elses, makes code readable 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum support for SetState and GetState added