Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load flyway configuration from env vars #389

Merged
merged 3 commits into from
Apr 25, 2024
+1 −0
Merged

feat: load flyway configuration from env vars #389

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
293c46a
feat: load flyway configuration from env vars
slivkamiro Mar 14, 2024
0a3a838
update flyway version
slivkamiro Mar 14, 2024
83a9892
Revert "update flyway version"
slivkamiro Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Flyway module for Play 2.4 or later. It aims to be a substitute for play-evoluti

| flyway-play version | play version | flyway version |
| ------------------- | ------------ | -------------- |
| 9.0.1 | 3.0.x | 9.19.4 |
| 9.0.0 | 3.0.x | 9.16.0 |
| 8.0.1 | 2.9.x | 9.16.0 |
| 7.38.0 | 2.8.x | 9.16.0 |
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ val flywayPlayVersion = "9.0.0"
val scalaVersion_2_13 = "2.13.12"
val scalaVersion_3 = "3.3.1"

val flywayVersion = "9.16.3"
val flywayVersion = "9.19.4"
val scalikejdbcVersion = "4.1.0"

val scalatest = "org.scalatest" %% "scalatest" % "3.2.17" % "test"
Expand Down
1 change: 1 addition & 0 deletions plugin/src/main/scala/org/flywaydb/play/Flyways.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class Flyways @Inject() (configuration: Configuration, environment: Environment)
configuration.outOfOrder.foreach(flyway.outOfOrder)
configuration.mixed.foreach(flyway.mixed)
configuration.group.foreach(flyway.group)
flyway.envVars()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slivkamiro. This looks good to me.
Could you remove changes in README.md and build.sbt?
I want to decide what version it should be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, reverted


dbName -> flyway.load()
}
Expand Down