Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for additional package.json attributes #11

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

adierkens
Copy link
Member

@adierkens adierkens commented Jul 20, 2022

Release Notes

Adds new rules to the package.json creation pipeline:

Adds merge_json rule to flatten multiple json files into one. This can be combined with the base_package_json attribute to create more dynamic package attributes.

Adds a create_contributors rule for generating the contributors section of a package.json from an .all-contributorsrc

Example:

load("@rules_player//javascript/package_json:index.bzl", "merge_json", "create_contributors")

create_contributors(
    name = "pkg_json_contrib",
    all_contributors = "//:.all-contributorsrc",
)

merge_json(
    name = "pkg_json_template",
    srcs = [
        "package-template.json",
        ":pkg_json_contrib",
    ]
)

@adierkens adierkens added the minor Increment the minor version when merged label Jul 20, 2022
@adierkens adierkens changed the title [WIP] Better support for additional package.json attributes Better support for additional package.json attributes Jul 21, 2022
@adierkens adierkens merged commit ddfa9ca into main Jul 21, 2022
@adierkens adierkens deleted the pkg-attrs branch July 21, 2022 20:55
@intuit-svc
Copy link

🚀 PR was released in v0.5.0 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants