Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FBJNI local binaries #516

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Remove FBJNI local binaries #516

merged 2 commits into from
Sep 26, 2024

Conversation

brocollie08
Copy link
Contributor

@brocollie08 brocollie08 commented Sep 26, 2024

Removed locally built FBJNI and C++ libraries for Hermes since it's now made available on Maven

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.9.1-next.3

Changelog

🐛 Bug Fix

Authors: 5

@brocollie08 brocollie08 added the patch Increment the patch version when merged label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (a3d9959) to head (ee7672d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   92.84%   91.89%   -0.95%     
==========================================
  Files         341      341              
  Lines       27232    27232              
  Branches     1944     1944              
==========================================
- Hits        25284    25026     -258     
- Misses       1948     2192     +244     
- Partials        0       14      +14     
Flag Coverage Δ
91.89% <ø> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brocollie08 brocollie08 merged commit f270369 into main Sep 26, 2024
10 of 11 checks passed
@brocollie08 brocollie08 deleted the remove-fbjni-local-binaries branch September 26, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant