Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rules Versions #496

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Update Rules Versions #496

merged 5 commits into from
Aug 30, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Aug 28, 2024

Release Notes

Update JS Rules to latest Aspect major

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@KetanReddy KetanReddy added the skip-release Preserve the current version when merged label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (e8f3a23) to head (ae9a118).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         340      340           
  Lines       26960    26960           
  Branches     1945     1945           
=======================================
  Hits        24796    24796           
  Misses       2150     2150           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy marked this pull request as ready for review August 28, 2024 03:07
@KetanReddy KetanReddy requested a review from adierkens as a code owner August 28, 2024 03:07
@KetanReddy KetanReddy requested a review from a team August 28, 2024 03:18
@KetanReddy KetanReddy changed the title Updates Rules Versions Update Rules Versions Aug 28, 2024
@KetanReddy KetanReddy force-pushed the maint/update-js-rules branch from 8eea23a to 71050c1 Compare August 28, 2024 18:41
@KetanReddy KetanReddy linked an issue Aug 28, 2024 that may be closed by this pull request
@KetanReddy KetanReddy force-pushed the maint/update-js-rules branch from 1a88cba to 4163fec Compare August 29, 2024 20:30
@KetanReddy KetanReddy merged commit ccc758a into main Aug 30, 2024
11 checks passed
@KetanReddy KetanReddy deleted the maint/update-js-rules branch August 30, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prep for Rules JS 2.0.0
2 participants