Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alternate binding parsers from bundle #432

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

adierkens
Copy link
Member

@adierkens adierkens commented Jul 15, 2024

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
📦 Published PR as canary version: 0.7.5--canary.432.14776

Try this version out locally by upgrading relevant packages to 0.7.5--canary.432.14776

Comparison of bundle size in bundlephobia: https://bundlephobia.com/package/@player-ui/react@0.7.5--canary.432.14776

CleanShot 2024-07-15 at 11 40 36

@adierkens adierkens force-pushed the binding-parser-bundle branch from 59993c8 to 2bf394d Compare July 15, 2024 13:50
@adierkens adierkens force-pushed the binding-parser-bundle branch from 2bf394d to 71ed37f Compare July 15, 2024 14:08
@adierkens
Copy link
Member Author

/canary

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (aafb87a) to head (71ed37f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   91.75%   91.71%   -0.05%     
==========================================
  Files         339      337       -2     
  Lines       27044    26779     -265     
  Branches     1963     1936      -27     
==========================================
- Hits        24814    24560     -254     
+ Misses       2216     2205      -11     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adierkens adierkens marked this pull request as ready for review July 15, 2024 15:38
@adierkens adierkens requested a review from KetanReddy as a code owner July 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants