Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 162] iOS: Add footer to info reference asset #194

Merged
merged 5 commits into from
Oct 20, 2023
Merged

[Issue 162] iOS: Add footer to info reference asset #194

merged 5 commits into from
Oct 20, 2023

Conversation

kurultai
Copy link
Contributor

@kurultai kurultai commented Oct 19, 2023 •
edited by hborawski
Loading

resolves #162

Added optional footer asset to bottom of info reference asset, for the SwiftUI reference asset

Demo mock:

Screenshot 2023-10-19 at 8 24 58 AM

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@hborawski hborawski added skip-release Preserve the current version when merged hacktoberfest hacktoberfest-accepted labels Oct 19, 2023
@hborawski hborawski merged commit 221296b into player-ui:main Oct 20, 2023
This was referenced Oct 26, 2023
Merged
Merged
This was referenced Nov 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mercillo mercillo mercillo approved these changes

@hborawski hborawski hborawski approved these changes

@adierkens adierkens Awaiting requested review from adierkens adierkens is a code owner

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: Add footer to info reference asset
3 participants
@kurultai @hborawski @mercillo