Fallback Webgl1 solution for depth grab is replaced by a RenderPassDepth #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
387
to
+389
| this.webgl2 = typeof WebGL2RenderingContext !== 'undefined' && gl instanceof WebGL2RenderingContext; | ||
| this.isWebGl2 = this.webgl2; | ||
| this.isWebGl1 = !this.webgl2; |
There was a problem hiding this comment.
Should webgl2 be moved to deprecated.js?
There was a problem hiding this comment.
yes, I will do in a separate PR as it will have many changes.
Co-authored-by: Will Eastcott <will@playcanvas.com>
willeastcott
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WebGL1, we no longer use a custom Depth layer with render target and some manual handling of visible mesh instances under the hood, but have a render pass that is scheduled to run before the camera's render pass to render the depth.
DEPRECATED: pc.Layer#renderTargetNew public API:
to match existing