Fixes sheen intensity #4697
Merged
Fixes sheen intensity #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngine into gsterbrant_sheen_spec_fixes
…heen was a mistake. Also revert the mip offset reflection sampling. Also, sheen should not be a factor of the materials reflectivity.
willeastcott
approved these changes
Oct 5, 2022
|
I hope this can go in 1.57.1 as it's a nasty bug affecting all cloth materials. |
|
This PR is also updating clearcoat. Is that intended? You don't mention this in the description. |
|
@slimbuck Thanks! Had forgotten about that. Added it to the comment. |
mvaligursky
approved these changes
Oct 6, 2022
mvaligursky
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Fix double clearcoat spec multiplication. * Use CC fresnel for lights * Use CC fresnel for lights * Add reflection sample with base mip offset for materials * Defer multiplication of sheen specular color to combine step. * We don't use reciprocal PI for energy preservation, so doing it for sheen was a mistake. Also revert the mip offset reflection sampling. Also, sheen should not be a factor of the materials reflectivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our analytical approach inspired by Three.js inconsistently divides by PI to balance the energy over the hemisphere. This caused a strong reduction in sheen light intensities.
Furthermore, we also used the roughness of the sheen to sample different environment mips, but sampling the lowest mip is more correct as reflections will always be extremely rough, seeing as sheen is simulating quite big microfibers.
Before:
After:
This PR also fixes an issue where clear coat was using the specular color to tint reflections. According to the glTF spec, the f0 for clear coat is always white.