Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Declare standard material maps as nullable #4165

Merged
merged 1 commit into from
Apr 2, 2022
Merged

[FIX] Declare standard material maps as nullable #4165

merged 1 commit into from
Apr 2, 2022

Conversation

willeastcott
Copy link
Contributor

Tweak declarations of maps on the StandardMaterial to be nullable.

Fixes #4164

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added bug area: graphics Graphics related issue labels Apr 2, 2022
@willeastcott willeastcott requested a review from a team April 2, 2022 18:25
@willeastcott willeastcott self-assigned this Apr 2, 2022
@willeastcott willeastcott merged commit fc9dcf4 into main Apr 2, 2022
@willeastcott willeastcott deleted the nullable-maps branch January 7, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@willeastcott willeastcott

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StandardMaterial nullable fields not aligned with docs
2 participants
@willeastcott @mvaligursky