[FIX] Ensure consistent function return types #4153
Conversation
|
Remaining problems that still need fixing:
|
|
Should the build step replace
Another option that helps with detecting this is to enable
|
|
Yeah, I think such a micro-optimization is probably not worth it. 😄 I'll take a look at the |
| @@ -1471,11 +1471,11 @@ class Application extends EventHandler { | |||
| * @returns {object} A object containing the values calculated to use as width and height. | |||
| */ | |||
| resizeCanvas(width, height) { | |||
| if (!this._allowResize) return; // prevent resizing (e.g. if presenting in VR HMD) | |||
| if (!this._allowResize) return undefined; // prevent resizing (e.g. if presenting in VR HMD) | |||
There was a problem hiding this comment.
I think these should be null instead of undefined .. as the return type is object.
There was a problem hiding this comment.
Possibly. I'm mainly just trying to keep the functionality identical and satisfy ESLint.
| Debug.error(`batch group with id ${id} already exists`); | ||
| return; | ||
| Debug.error(`Batch group with id ${id} already exists.`); | ||
| return undefined; |
There was a problem hiding this comment.
maybe it could return this._batchGroups[id] so that the code would still work
There was a problem hiding this comment.
Again, it'd be changing functionality. I'd rather address that separately.
There are several places in the codebase where a function has inconsistent return types. These problems are spotted by the ESLint rule
consistent-return. This PR attempts to fix these problems with a view to enabling this rule in the future.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.