Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnimComponent] Transition bug fix #3892

Merged
merged 1 commit into from
Jan 11, 2022
Merged

[AnimComponent] Transition bug fix #3892

merged 1 commit into from
Jan 11, 2022

Conversation

ellthompson
Copy link
Contributor

There was a bug in the anim controllers update method which caused transitions to have no transition duration. This was caused by the incorrect checking of zero total transition times before a division.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@ellthompson ellthompson added the area: animation Animation related issue label Jan 11, 2022
@ellthompson ellthompson requested a review from a team January 11, 2022 14:04
@ellthompson ellthompson self-assigned this Jan 11, 2022
Copy link
Collaborator

@yaustar yaustar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellthompson ellthompson merged commit a26bba3 into dev Jan 11, 2022
@ellthompson ellthompson deleted the transition-bug branch January 11, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animation Animation related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants