-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen Space Ambient Occlusion post effect #3266
Conversation
|
||
scope.resolve("uSSAOBuffer").setValue(this.targets[0].colorBuffer); | ||
|
||
// scope.resolve("uFarPlaneOverEdgeDistance").setValue(cameraFarClip / bilateralThreshold); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this line if not required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with various suggestions and comments.
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Can please the shader code be moved to a separate file? Making it more usable than it is when written within JS? |
I agree it's not ideal, but it matches the style of all post effects - it's a single file with all shaders inlined. |
Fixes: #1136
Based on #3092, thank you to @raytranuk for an excellent contribution. This PR in addition to the initial PR exposed few parameters and did few small changes related to parameters. I also make it to work on Webgl1.
The implementation is based on the code in Filament Engine: https://github.com/google/filament
example of using the effect on a camera: